WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

Issue/17453-Multi line display of text in 'About me'

Open Agoni-0 opened this issue 1 year ago • 2 comments

Fixes #


Description: This issue in related to issue/17453. This issue describes a problem that the "About me" text field is a short field, like "name" which means it's not possible to see the full text. image I found that this is caused by the incorrect settings of multiple line representation of the 'EditText'.

To Test:

Due to the ’My Profile‘ page not displaying during debugging, I modified the code and used a small demo to test it. This demo consists of relevant components from the source code. I have tested it on both real and virtual device. It seems that it works well. Screenshot_20241018_015915_com example myapplication


Regression Notes

  1. Potential unintended areas of impact

    • None. I have also tested single line display when the control parameter is 'false'. It's fine.

image

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

    • I make a small demo and test the code on both real and virtual device.
  2. What automated tests I added (or what prevented me from doing so)

    • None. ’My Profile‘ page not displaying during debugging.

PR Submission Checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] Talkback.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] Large and small screen sizes. (Tablet and smaller phones)
  • [ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Agoni-0 avatar Oct 17 '24 18:10 Agoni-0

@Agoni-0 Thanks so much for your contribution! I'll be reviewing this shortly.

nbradbury avatar Oct 17 '24 18:10 nbradbury

@Agoni-0 Fix looks but one change is required: it seems that gradle.properties-example was accidentally deleted in this PR, and that's a critical file for contributors. Once that's restored I'll approve and merge.

nbradbury avatar Oct 21 '24 20:10 nbradbury