WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard
verified publisher icon wordpress-mobile

🤖 Adds accessibility descriptions on inline actions

Open antonis opened this issue 2 years ago • 2 comments

Fixes #20212

To Test:

  1. Open the notifications tab
  2. Turn talkback on
  3. Browse through the list
  4. Focus on a liked post or comment
  5. Verify that it is announce as "Liked"
  6. Focus on a not like post or comments
  7. Verify that the "Like" action is announced
  8. Focus on a sharable post
  9. Verify that the "Share" action is announced
  10. Verify that no action is announced on list items without an action

Regression Notes

  1. Potential unintended areas of impact

    • Notifications

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing

  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist:

  • [ ] I have completed the Regression Notes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] Talkback.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] Large and small screen sizes. (Tablet and smaller phones)
  • [ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

antonis avatar Feb 20 '24 12:02 antonis

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20214-1aaecf7
Commit1aaecf745716f27f7469247b7fe5820255f19365
Direct Downloadjetpack-prototype-build-pr20214-1aaecf7.apk
Note: Google Login is not supported on these builds.

wpmobilebot avatar Feb 20 '24 12:02 wpmobilebot

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20214-1aaecf7
Commit1aaecf745716f27f7469247b7fe5820255f19365
Direct Downloadwordpress-prototype-build-pr20214-1aaecf7.apk
Note: Google Login is not supported on these builds.

wpmobilebot avatar Feb 20 '24 12:02 wpmobilebot

Thank you for reviewing @mkevins 🙇

One subtle observation is that I had to swipe over to the button to hear it announced. I.e. the liked or not-liked status was not announced on the notification itself.

Good point 👍 Tbh I didn't consider this and went with the just adding the status on the button for simplicity. Thinking of it now I think it might complicate the announcement since the like status would need to be duplicated on the action button 🤔

antonis avatar Feb 21 '24 07:02 antonis

it might complicate the announcement since the like status would need to be duplicated on the action button

True, which I think means I'd lean toward leaving it as is.. I just wanted to mention this in case it was unexpected, because when I read the testing steps, I thought it would announce it on each row. Tbh, I'm not a "typical user" of talkback, so I don't have a sense of "normal". It seems ok to me, though, to have the button be separate, and have the announcement only on it. 🤷‍♂️

mkevins avatar Feb 21 '24 07:02 mkevins

I'll leave this as is for now and we may iterate if we have accessibility feedback on this.

antonis avatar Feb 21 '24 08:02 antonis