Refactors for notifications - Part 2

[jarvislin]

Part of pc8HXX-1ua-p2

This PR contains:

---

To Test:

---

Regression Notes

1. Potential unintended areas of impact

   • notifications tab

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   • manual

3. What automated tests I added (or what prevented me from doing so)

   • none

---

PR Submission Checklist:

• [ ] I have completed the Regression Notes.
• [ ] I have considered adding accessibility improvements for my changes.
• [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

---

Testing Checklist:

• [ ] WordPress.com sites and self-hosted Jetpack sites.
• [ ] Portrait and landscape orientations.
• [ ] Light and dark modes.
• [ ] Fonts: Larger, smaller and bold text.
• [ ] High contrast.
• [ ] Talkback.
• [ ] Languages with large words or with letters/accents not frequently used in English.
• [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• [ ] Large and small screen sizes. (Tablet and smaller phones)
• [ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[dangermattic]

	2 Errors
:no_entry_sign:	Please add tests for class NotesAdapter (or add unit-tests-exemption label to ignore this).
:no_entry_sign:	Please add tests for class WPViewPagerTransformer2 (or add unit-tests-exemption label to ignore this).

	1 Warning
:warning:	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

	1 Message
:book:	This PR is still a Draft: some checks will be skipped.

Generated by :no_entry_sign: Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20208-dcf1078
	Commit	dcf10787b242a0dfd79e4311db8b6a0b76bfdaf8
	Direct Download	wordpress-prototype-build-pr20208-dcf1078.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20208-dcf1078
	Commit	dcf10787b242a0dfd79e4311db8b6a0b76bfdaf8
	Direct Download	jetpack-prototype-build-pr20208-dcf1078.apk

Note: Google Login is not supported on these builds.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 40.17%. Comparing base (96d72f8) to head (890aa3a).

:exclamation: Current head 890aa3a differs from pull request most recent head e6186fb. Consider uploading reports for the commit e6186fb to get more accurate results

Files	Patch %	Lines
.../ui/notifications/NotificationsListFragmentPage.kt	0.00%	3 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #20208      +/-   ##
==========================================
- Coverage   40.40%   40.17%   -0.23%     
==========================================
  Files        1459     1470      +11     
  Lines       67165    67777     +612     
  Branches    11150    11240      +90     
==========================================
+ Hits        27135    27228      +93     
- Misses      37548    38052     +504     
- Partials     2482     2497      +15     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[sonarqubecloud[bot]]

Quality Gate failed

Failed conditions
28.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud