WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

Updates Jetpack banners and badges copy

Open antonis opened this issue 1 year ago • 8 comments

Description

Updates Jetpack banners and badges copy for consistency (internal ref pcdRpT-5EP-p2)

⚠️ Please do not merge till a decision is made on pcdRpT-5EP-p2


To Test:

  1. Open the WordPress app from this PR
  2. Verify that the copy Jetpack powered is displayed in the following screens:
  • Activity logs
  • Themes
  • Social
  • People
  • Me tab
  • App Settings
Activity logs Themes
Screenshot_20240205_123320 Screenshot_20240205_123342
Social People
Screenshot_20240205_123403 Screenshot_20240205_123427
Me tab App Settings
Screenshot_20240205_123447 Screenshot_20240205_123504

Regression Notes

  1. Potential unintended areas of impact

    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    Manual testing

  3. What automated tests I added (or what prevented me from doing so)

    Updated existing testcase


PR Submission Checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] Talkback.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] Large and small screen sizes. (Tablet and smaller phones)
  • [ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

antonis avatar Feb 05 '24 10:02 antonis

Warnings
:warning: This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by :no_entry_sign: dangerJS

1 Warning
:warning: This PR is assigned to the milestone 24.3 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.
1 Message
:book: This PR contains changes to RELEASE-NOTES.txt.
Note that these changes won't affect the final version of the release notes as this version is in code freeze.
Please, get in touch with a release manager if you want to update the final release notes.

Generated by :no_entry_sign: Danger

dangermattic avatar Feb 05 '24 10:02 dangermattic

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20123-837acd6
Commit837acd6b17c5c0883801d3d1981860b7887d722c
Direct Downloadwordpress-prototype-build-pr20123-837acd6.apk
Note: Google Login is not supported on these builds.

wpmobilebot avatar Feb 05 '24 11:02 wpmobilebot

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20123-837acd6
Commit837acd6b17c5c0883801d3d1981860b7887d722c
Direct Downloadjetpack-prototype-build-pr20123-837acd6.apk
Note: Google Login is not supported on these builds.

wpmobilebot avatar Feb 05 '24 11:02 wpmobilebot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3b3fa12) 40.18% compared to head (837acd6) 40.18%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release/24.3   #20123   +/-   ##
=============================================
  Coverage         40.18%   40.18%           
=============================================
  Files              1469     1469           
  Lines             67665    67665           
  Branches          11208    11208           
=============================================
  Hits              27193    27193           
  Misses            37978    37978           
  Partials           2494     2494           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 05 '24 11:02 codecov[bot]

👋 Thanks for the copy review ping! For consistency, I'd recommend:

Powered by Jetpack

It's clean and clear.

kristastevens avatar Feb 05 '24 16:02 kristastevens

@antonis I'm cutting the 24.2 release branch in a few minutes, so feel free to update the base branch of this PR to release/24.2 so that it can be included in that version.

spencertransier avatar Feb 05 '24 21:02 spencertransier

👋 Thanks for the copy review ping! For consistency, I'd recommend:

Powered by Jetpack

Thank you for the prompt response and the feedback @kristastevens 🙇 I'll wait for internal feedback on this before proceeding with the change (ref pcdRpT-5EP-p2#comment-8984).

antonis avatar Feb 08 '24 09:02 antonis

Thank you for reviewing @mkevins 🙇

antonis avatar Feb 23 '24 07:02 antonis