WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

Merge release branch after 20.8-rc-2 beta

Open AliSoftware opened this issue 3 years ago • 3 comments

Merging the release branch after doing a new beta.

The new beta includes:

  • https://github.com/wordpress-mobile/WordPress-Android/pull/17185
  • https://github.com/wordpress-mobile/WordPress-Android/pull/17189 to include https://github.com/wordpress-mobile/WordPress-FluxC-Android/pull/2527
  • Latest strings.xml from GlotPress — had to manually fix values-cs in 6f4327df60d3c529870f5ece7d0989e8a80f7f5a due to placeholder inconsistencies in the translation (asked a GTE to reject it in GlotPress since)
  • Version bump in version.properties

AliSoftware avatar Sep 21 '22 19:09 AliSoftware

Found 1 violations:

The PR caused the following dependency changes:

-+--- org.wordpress:fluxc:{strictly 1.54.0} -> 1.54.0
-|    +--- org.wordpress:wellsql:1.7.0
-|    |    \--- org.wordpress.wellsql:wellsql-annotations:1.7.0
-|    +--- org.wordpress.fluxc:fluxc-annotations:1.54.0
-|    +--- org.greenrobot:eventbus:3.3.1 (*)
-|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.9.2 (*)
-|    +--- com.android.volley:volley:1.1.1 -> 1.2.0
-|    +--- androidx.paging:paging-runtime:2.1.2
-|    |    +--- androidx.paging:paging-common:2.1.2
-|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.1.0 (*)
-|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.1.0 (*)
-|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.4.1 (*)
-|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.4.1 (*)
-|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
-|    +--- com.goterl:lazysodium-android:5.0.2
-|    +--- net.java.dev.jna:jna:5.5.0
-|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
-|    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.10 (*)
-|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.3.1 (*)
-|    +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
-|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.2.0 (*)
-|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2
-|    |    +--- com.squareup.okhttp3:okhttp:4.9.2 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.6.10 (*)
-|    +--- com.google.code.gson:gson:2.8.5
-|    +--- org.apache.commons:commons-text:1.1 (*)
-|    +--- androidx.room:room-runtime:2.4.2 (*)
-|    +--- androidx.room:room-ktx:2.4.2
-|    |    +--- androidx.room:room-common:2.4.2 (*)
-|    |    +--- androidx.room:room-runtime:2.4.2 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
-|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
-|    +--- com.google.dagger:dagger:2.42 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.5.2 (*)
-|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.5.2 (*)
++--- org.wordpress:fluxc:{strictly 1.54.1} -> 1.54.1
+|    +--- org.wordpress:wellsql:1.7.0
+|    |    \--- org.wordpress.wellsql:wellsql-annotations:1.7.0
+|    +--- org.wordpress.fluxc:fluxc-annotations:1.54.1
+|    +--- org.greenrobot:eventbus:3.3.1 (*)
+|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.9.2 (*)
+|    +--- com.android.volley:volley:1.1.1 -> 1.2.0
+|    +--- androidx.paging:paging-runtime:2.1.2
+|    |    +--- androidx.paging:paging-common:2.1.2
+|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
+|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.1.0 (*)
+|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.1.0 (*)
+|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.4.1 (*)
+|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.4.1 (*)
+|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
+|    +--- com.goterl:lazysodium-android:5.0.2
+|    +--- net.java.dev.jna:jna:5.5.0
+|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
+|    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.10 (*)
+|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.3.1 (*)
+|    +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
+|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.2.0 (*)
+|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2
+|    |    +--- com.squareup.okhttp3:okhttp:4.9.2 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.6.10 (*)
+|    +--- com.google.code.gson:gson:2.8.5
+|    +--- org.apache.commons:commons-text:1.1 (*)
+|    +--- androidx.room:room-runtime:2.4.2 (*)
+|    +--- androidx.room:room-ktx:2.4.2
+|    |    +--- androidx.room:room-common:2.4.2 (*)
+|    |    +--- androidx.room:room-runtime:2.4.2 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
+|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
+|    +--- com.google.dagger:dagger:2.42 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.5.2 (*)
+|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.5.2 (*)
 \--- org.wordpress:login:0.19.0
-     \--- org.wordpress:fluxc:1.50.0 -> 1.54.0 (*)
+     \--- org.wordpress:fluxc:1.50.0 -> 1.54.1 (*)

Please review and act accordingly

<this is a auto generated comment from violation-comments-lib F7F8ASD8123FSDF>

<ACCUMULATED-VIOLATIONS>

wpmobilebot avatar Sep 21 '22 19:09 wpmobilebot

You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr17193-6f4327d.apk), or scanning this QR code:

wpmobilebot avatar Sep 21 '22 19:09 wpmobilebot

You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr17193-6f4327d.apk), or scanning this QR code:

wpmobilebot avatar Sep 21 '22 19:09 wpmobilebot

Question (❓): I am seeing the manually amend values-cs.xml to fix the lint errors, thank you for that! 🥇 However, I am seeing two different resolutions and I was wondering why:

Answer is simple:

  • The first one was an easy fix for which I knew that the introduction of %1$s in the original was just to replace the term WordPress, so that was a safe bet to fix myself like I did. I considered removing it entirely, but figured replacing Wordpressu with %1$s was a good bet.
  • The second one was more complicated, especially I wasn't convinced that the order of the parameters didn't change (i.e. previous copy had %3$s as the text to put after the new line, and new copy had %4$s in that place instead, because Wordpressu was already a placeholder in 3rd position. Maybe replacing Wordpressu with %3$s and then replacing the old %3$s with %4$s would have been enough of a fix, but I felt less confident on this one, so preferred to just delete it and let polyglots fix it properly in GlotPress anyway.

AliSoftware avatar Sep 22 '22 07:09 AliSoftware

And as always, thanks for your extra attention to detail on those reviews @ParaskP7 🙇

Merging this now that the question was clarified 🙂 (and next beta—or final release—will have the Czech entry removed or replaced anyway since those have been fixed in GlotPress since)

AliSoftware avatar Sep 22 '22 07:09 AliSoftware

Thank you for all this clarification @AliSoftware , much appreciated, it makes sense! 👍

ParaskP7 avatar Sep 22 '22 07:09 ParaskP7