WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard
verified publisher icon wordpress-mobile

Quick Start: Retain Quick Start focus point after device rotation #16656

Open gitstart opened this issue 3 years ago • 1 comments

Fixes #16656 Quick Start: Retain Quick Start focus point after device rotation

Add the current active QuickStartFocus point to the savedInstanceState when the device is rotated and retrieve it when it is recreated

To test:

  1. Launch the app.
  2. Logout and log in.
  3. Select an existing site from the Login Epilogue screen.
  4. Select Show me around on the onboarding Quick Start dialogue.
  5. Go to My Site tab.
  6. Notice that the Quick Start card is shown for the existing site with the title Get to know your app.
  7. Tap on the Quick Start card then tap on Check your notifications in the tasks modal.
  8. Notice that the Quick Start focus point is shown on the notifications tab.
  9. Rotate the device
  10. Notice that the Quick Start focus point is still shown on the notifications tab.

Regression Notes

  1. Potential unintended areas of impact NONE

  2. What I did to test those areas of impact (or what existing automated tests I relied on) Virtual testing

  3. What automated tests I added (or what prevented me from doing so) None

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Bug loom https://www.loom.com/share/d8ae5978f2534b9dbdd08ab78c031156

Fix loom video https://www.loom.com/share/1ffba7f5d8034a13b823ca7166d1ebbf

NB On how to setup see the Bug loom video

gitstart avatar Sep 21 '22 07:09 gitstart

@gitstart Thanks for working on this issue. I will review this PR in a couple of days. Sorry for the delay.

PS for anyone from WordPress mobile team: If anyone wants to review this PR, please go ahead as it might take a couple of days(2-3) for me to have the bandwidth for looking at the PR.

AjeshRPai avatar Sep 21 '22 07:09 AjeshRPai

🎉 This PR now made it to the 20.9-rc-1 beta. We will now start the beta-testing phase for version 20.9 (which lasts two weeks) before rolling that version 20.9 out to end users.

Watch https://make.wordpress.org/mobile/ for the upcoming Call for Testing for WPAndroid 20.9 and to learn how to help with the beta test of this version (including your changes from this PR)!

AliSoftware avatar Oct 03 '22 11:10 AliSoftware