WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

Reader: "Manage Topics & Sites" not translated #17112

Open gitstart opened this issue 3 years ago • 1 comments

Fixes #17112

Solution: Title needs to be set from Activity, instead label from manifest. As label is not get updated during runtime.

To test:

  1. In Me > App Settings, change Interface Language to one of the Mag16 languages.
  2. Head into Reader and tap the "gear" icon.
  3. Note that "Manage Topics & Sites" is in English.

Regression Notes

  1. Potential unintended areas of impact None
  2. What I did to test those areas of impact (or what existing automated tests I relied on) Visual testing
  3. What automated tests I added (or what prevented me from doing so) None, visual testing was enough

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Demo

Video Demo

gitstart avatar Sep 15 '22 09:09 gitstart

🎉 This PR now made it to the 20.9-rc-1 beta. We will now start the beta-testing phase for version 20.9 (which lasts two weeks) before rolling that version 20.9 out to end users.

Watch https://make.wordpress.org/mobile/ for the upcoming Call for Testing for WPAndroid 20.9 and to learn how to help with the beta test of this version (including your changes from this PR)!

AliSoftware avatar Oct 03 '22 11:10 AliSoftware