woocommerce-android icon indicating copy to clipboard operation
woocommerce-android copied to clipboard

[Woo POS][Refunds] Confirm refund step

Open samiuelson opened this issue 4 months ago • 3 comments

WOOMOB-1826

Description

This PR adds a confirmation step to the WooCommerce POS refund flow, allowing users to confirm their refund decision before processing.

Design: DK955L5K0bTfkjrHTBLmqo-fi-289_11772

Not included in this PR:

  • Via (payment method) - now hardcoded, will be replaced with real value in next iteration.

Test Steps

  1. Go to POS > Orders
  2. Tap "Issue Refund" button and follow the refund flow

Images/gif

image
  • [x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

samiuelson avatar Dec 05 '25 16:12 samiuelson

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitf3c7e8240ba9efa39f264e41e68626452c549fac
Direct Downloadwoocommerce-wear-prototype-build-pr15065-f3c7e82.apk

wpmobilebot avatar Dec 05 '25 16:12 wpmobilebot

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitf3c7e8240ba9efa39f264e41e68626452c549fac
Direct Downloadwoocommerce-prototype-build-pr15065-f3c7e82.apk

wpmobilebot avatar Dec 05 '25 16:12 wpmobilebot

Codecov Report

:x: Patch coverage is 4.00000% with 192 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 38.62%. Comparing base (e96be1f) to head (f3c7e82). :warning: Report is 20 commits behind head on trunk.

Files with missing lines Patch % Lines
...ndroid/ui/woopos/orders/WooPosIssueRefundDialog.kt 0.00% 190 Missing :warning:
...ce/android/ui/woopos/orders/WooPosRefundUIEvent.kt 50.00% 1 Missing :warning:
.../android/ui/woopos/orders/WooPosRefundViewModel.kt 83.33% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #15065      +/-   ##
============================================
- Coverage     38.67%   38.62%   -0.06%     
- Complexity    10397    10398       +1     
============================================
  Files          2169     2169              
  Lines        123263   123460     +197     
  Branches      17018    17039      +21     
============================================
+ Hits          47673    47681       +8     
- Misses        70779    70967     +188     
- Partials       4811     4812       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Dec 09 '25 18:12 codecov-commenter

1 Warning
:warning: This PR is assigned to the milestone 23.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

dangermattic avatar Dec 12 '25 08:12 dangermattic

Thanks @samiuelson!

The code looks good. I have two notes regarding the designs:

  1. Seems like the text color of the message doesn't match figma - it's grey in the app but black in figma.
  2. I realize, the implementation matches figma, but I'd suggest adding one extra empty line between the first sentence and the second sentence. Right now it feels quite off on a basic emulator - I think Wagner assumed the first sentence would fit one line which isn't the case on most devices (and likely most languages).

Done! bbc8a34 and f3c7e82

samiuelson avatar Dec 12 '25 09:12 samiuelson