wc-api-ruby icon indicating copy to clipboard operation
wc-api-ruby copied to clipboard

migrate from URI.encode to CGI::escape to become ruby 3 ready

Open stevereinke opened this issue 3 years ago • 2 comments

Hi there.

It would be nicce to use your lib also with ruby 3. Can you check these changes and take this pull request?

Thanks in advance.

Kind regards Steve

stevereinke avatar Feb 01 '23 15:02 stevereinke

If anybody is interested to know why Addressable gem is used to escape the URL, here is the detailed answer https://stackoverflow.com/a/13059657/663660

sonianand11 avatar Jun 22 '23 10:06 sonianand11

Any chance we get this merged?

cc @claudiosanches @choubacha @danielhoey

ricvillagrana avatar Feb 16 '24 23:02 ricvillagrana