wc-api-php icon indicating copy to clipboard operation
wc-api-php copied to clipboard

Update PHPDoc

Open midweste opened this issue 1 year ago • 1 comments

Updated phpdocs to include returning a stdClass OR an array. Some endpoints return an array and IDE intelligence flags errors.

midweste avatar Oct 23 '24 18:10 midweste

@claudiosanches Last commits over three years old, are there any maintainers here that can approve pull requests?

midweste avatar Feb 18 '25 14:02 midweste

ping @claudiosanches

dereuromark avatar Jul 18 '25 02:07 dereuromark

@adimoldovan I see you committed most recently here, anyone able to address pull requests?

midweste avatar Jul 18 '25 02:07 midweste

@adimoldovan I see you committed most recently here, anyone able to address pull requests?

This repo will be maintained by @woocommerce/flux going forward.

adimoldovan avatar Jul 24 '25 10:07 adimoldovan

@midweste Can you provide testing instructions for this PR? I.e., endpoints that respond with both types.

joshuatf avatar Sep 08 '25 15:09 joshuatf

Here is two GET endpoints that return an array or stdclass:

https://woocommerce.github.io/woocommerce-rest-api-docs/?php#retrieve-an-order-note https://woocommerce.github.io/woocommerce-rest-api-docs/?php#list-all-order-notes

This convention seems to be followed across the board.

After browsing the api docs, I can't seem to find any that return array or stdclass for put, post, delete (and I don't even see any option calls defined in the api)

I'll put in a new pull request that only changes GET, processResponse, and request. Once I'm done, I'll link it here, we can close this one.

midweste avatar Sep 08 '25 17:09 midweste

Closed this and regenerated a new one changing get, request, and processResponse from latest trunk https://github.com/woocommerce/wc-api-php/pull/361

midweste avatar Sep 08 '25 17:09 midweste