storefront icon indicating copy to clipboard operation
storefront copied to clipboard
verified publisher icon woocommerce

PHP and JS automated tests fails when pushing code

Open danieldudzic opened this issue 3 years ago • 0 comments

When doing the 4.1.1 release, I have noticed a bunch of unrelated errors before merging the PR.

  1. Multiple instances of the same PHP error in inc/class-storefront.php: A hook was found, but was not accompanied by a docblock comment on the line above to clarify the meaning of the hook.

  2. JS Lint fail: ESLint issues detected.

  • Analyzing /home/runner/work/storefront/storefront/assets/js/woocommerce/extensions/brands.js
  • Analyzing /home/runner/work/storefront/storefront/assets/js/sticky-add-to-cart.js

It would be good to tidy this up, to make sure that new bugs won't fall through the cracks.  

danieldudzic avatar Jul 01 '22 15:07 danieldudzic