react-native-pdf icon indicating copy to clipboard operation
react-native-pdf copied to clipboard
verified publisher icon wonday

fix: Prevent crashes when canceling download tasks

Open wise-danya opened this issue 1 year ago • 4 comments

Description

This PR addresses a critical issue where the app crashes when attempting to cancel certain tasks within the PDF component. The crash occurs because the cancel method is called on lastRNBFTask without first checking if it is a function.

Problem

When the component updates, unmounts, or when a new download is initiated, the app attempts to cancel any ongoing task represented by lastRNBFTask. However, if lastRNBFTask.cancel is not a function, this leads to an uncaught exception, causing the app to crash.

Solution

Safety checks have been implemented to ensure that lastRNBFTask.cancel is a function before any attempt is made to call it. The existing checks for the presence of lastRNBFTask have been retained, and the cleanup behavior (setting lastRNBFTask to null) has been preserved.

Screenshots

componentDidUpdate componentWillUnmount

wise-danya avatar Sep 22 '24 00:09 wise-danya

Screenshot 2024-10-17 at 3 19 23 PM

We are experiencing same issue

WadhahEssam avatar Oct 17 '24 12:10 WadhahEssam

when is it possible to merge this, facing the same issue

Zakyyy avatar Jan 22 '25 06:01 Zakyyy

@wonday You could check this out

TheHypnoo avatar May 21 '25 08:05 TheHypnoo

@wonday any chance this could get merged? it's a minimal change and fixes a crash that we've been experiencing

jhhayashi avatar Aug 20 '25 15:08 jhhayashi

@wonday can you please check?

EugeniuszX avatar Jan 05 '26 08:01 EugeniuszX