wolfssl icon indicating copy to clipboard operation
wolfssl copied to clipboard

Fix benchmark failure on FIPS builds

Open bigbrett opened this issue 2 years ago • 3 comments

Description

Fixes bug where tls_bench can fail on FIPS builds in a multithreaded environment because of simultaneous attempts by client and server threads to run a CAST on-the-fly during the TLS handshake. This usually manifests itself as a KAT failure in ECC or AES, though I have seen a few other spurious error messages pop up depending on timing.

Bug reproduction

Try and run tls_bench on a multithreaded system on master and it should fail and report a KAT failure. Running on this branch should resolve the issue.

bigbrett avatar Jul 14 '23 19:07 bigbrett

Retest this please

dgarske avatar May 16 '24 18:05 dgarske

Retest this please

dgarske avatar May 16 '24 22:05 dgarske

Can't seem to get it to re-test or pass this macOS check in GitHub CI. I went ahead and rebased and force pushed. Let's see if we still get a failure.

dgarske avatar May 17 '24 14:05 dgarske