py_mesa_reader icon indicating copy to clipboard operation
py_mesa_reader copied to clipboard

fix: handle logarithm/exponentiation of luminosity

Open eekhof opened this issue 9 months ago • 0 comments

I stumbled upon an issue with the "luminosity" value not being treated correctly, and tried to solve it:

The history_colums.list does not include the non-logarithmic luminosity as "L", but as "luminosity". Because of this, the usual treatment of logarithmic and non-logarithmic values does not work, necessitating an explicit case for catching this. While the value "L" is available in the profile_columns.list, it coexists with "luminosity" there, leading to potential problems should anyone use this column title.

This patch fixes this by explicitly checking for the existence of "luminosity" in the log files in the case of a key error that could not be resolved by the other cases specified, or "log_L" should "luminosity" be asked for but not found.

I am looking forward to feedback on this, best, Lucas

eekhof avatar May 05 '25 14:05 eekhof