react-native-ui-lib icon indicating copy to clipboard operation
react-native-ui-lib copied to clipboard
verified publisher icon wix

Feat/segemented control new UI preset

Open nitzanyiz opened this issue 1 year ago • 4 comments

Description

Segmented Control Form preset added. I created a "hook" that returns new props according to the preset.

Changelog

SegmentedControl - New form preset added.

Additional info

MADS-4065

nitzanyiz avatar May 07 '24 13:05 nitzanyiz

@nitzanyiz Where is the example?

Inbal-Tish avatar May 12 '24 08:05 Inbal-Tish

@nitzanyiz Looks great. Left small comments. Also, I have a warning poping-up "Each child in a list should have a unique "key" prop. Check the render method of 'SegmentedControl'". Please take a look

Inbal-Tish avatar May 12 '24 09:05 Inbal-Tish

Oh sorry. Figma link:

Please don't add private links to the public repo. I meant the example in the demo screen...

Inbal-Tish avatar May 12 '24 09:05 Inbal-Tish

  • change to enum and set it on the component
  • added the preset change to the screen
  • removed the extra reanimated view if there is no divider.

nitzanyiz avatar May 13 '24 08:05 nitzanyiz