react-native-ui-lib icon indicating copy to clipboard operation
react-native-ui-lib copied to clipboard
verified publisher icon wix

new driver for hint testing

Open adids1221 opened this issue 2 years ago • 6 comments

Description

Hint - create new driver and refactor tests to it

Changelog

Additional info

adids1221 avatar Jan 16 '24 13:01 adids1221

@adids1221 I'd also remove the comment from the change log 🙏

M-i-k-e-l avatar Feb 07 '24 12:02 M-i-k-e-l

Also, nice work on the mock, I'm sure that was not easy 👍

M-i-k-e-l avatar Feb 07 '24 12:02 M-i-k-e-l

@M-i-k-e-l fix most of the comments, about the onBackgroundPress I'll try to add more test cases. And about the mock I'll try to ask Niryo and I'll update.

adids1221 avatar Feb 07 '24 15:02 adids1221

@M-i-k-e-l didn't finished yet, having some issues with the Modal - isVisble in the test. I'll ping you when all will be ready.

adids1221 avatar Feb 18 '24 14:02 adids1221

@M-i-k-e-l as we spoke we can't use isVisble on the Modal since it's not rendering to the screen.

adids1221 avatar Mar 19 '24 07:03 adids1221

Hi @adids1221, As discussed, please change the getOverlay and modalDriver (this is not the convention BTW) to specific getters

M-i-k-e-l avatar Mar 19 '24 09:03 M-i-k-e-l