Android Regression RN 0.73 - `onDropViewInstance` not called anymore, View not cleaned up

[bvonheid]

What happened?

With the update to RN 0.73 the onDropViewInstance of ViewManager is not called anymore when a screen is popped from the stack. As stated here for the onDropViewInstance:

Called when view is detached from view hierarchy and allows for some additional cleanup by the ViewManager subclass.

What was the expected behaviour?

onDropViewInstance should be called when a view is popped from the stack.

Was it tested on latest react-native-navigation?

• [X] I have tested this issue on the latest react-native-navigation release and it still reproduces.

Help us reproduce this issue!

You can reproduce the error in the playground app:

1. Run 7.38.1 on Android
2. Attach a Debugger to the App
3. Set a Breakpoint in the com/facebook/react/uimanager/ViewManager.class file in the onDropViewInstance Method
4. Click in Layout tab on Stack -> Push -> Pop
5. => After the Pop onDropViewInstance should be called, but it isn't

With the same steps with 7.37.2 onDropViewInstance is called.

In what environment did this happen?

React Native Navigation version: - React Native version: 0.73 Has Fabric (React Native's new rendering system) enabled: no Node version: - Device model: - Android version: -

[szaboa]

any update?

[szaboa]

any workaround then?

[tranhoangduong1994]

I am not using this navigation library but having a similar issue when working on a native app using embedded React native components. It seems to me that this issue is caused by the changes in React Native 0.73.

Currently, this issue leads to a lot of performance problems in our app due to memory used by native components not getting released when leaving screens.

The way that I'm working around this issue is to downgrade RN to 0.72.15.

[szaboa]

Yes we can also confirm that the issue is in React Native 0.73.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

[stale[bot]]

The issue has been closed for inactivity.