react-native-navigation icon indicating copy to clipboard operation
react-native-navigation copied to clipboard
verified publisher icon wix

Fix `kotlin` build issues with react native 73.x

Open siddarthkay opened this issue 2 years ago • 4 comments

In this PR we do the following :

  • We make sure react-native-navigation uses java 17 which is needed by react-native 0.73.1
  • We fix a type mismatch error when executing this gradle task :react-native-navigation:compileReactNative71DebugKotlin

fixes #7819

relevant patch in status-mobile repo : https://github.com/status-im/status-mobile/pull/18496/files#diff-b3d31b1df4cceb663a7dba96bcc3ea45686afe2208d7945b6e7e269067d753fbR100-R106

siddarthkay avatar Jan 16 '24 01:01 siddarthkay

Any status on release for this?

Spxc avatar Feb 02 '24 23:02 Spxc

Tests are failing, I'll try to fix the tests this weekend

siddarthkay avatar Feb 03 '24 02:02 siddarthkay

Tests are failing, I'll try to fix the tests this weekend

Thanks, i did a PR as well (with test failing, what a surprise haha), with a bit more changes to the ButtonPresenter

https://github.com/wix/react-native-navigation/pull/7842

Spxc avatar Feb 03 '24 10:02 Spxc

Hi @asafkorem @d4vidi @yogevbd How important is postCommandsOnMainThread_doesNotCrashIfActivityIsNull test? can this be skipped? This is the only test that fails on this PR when i run npm run test-unit-android -- --release

If not could you please provide some assistance here so that we can make progress on this PR :)

Thank you

siddarthkay avatar Mar 16 '24 15:03 siddarthkay

closing in favour of https://github.com/wix/react-native-navigation/pull/7864

siddarthkay avatar May 20 '24 07:05 siddarthkay