themes icon indicating copy to clipboard operation
themes copied to clipboard

bug: Solarized Light theme highlight doesn't match preview

Open achristmascarl opened this issue 2 years ago • 2 comments

Checks

  • [X] I have searched github.com/withfig/fig/issues and there are no duplicates of my issue
  • [X] I have run fig doctor in the affected terminal session
  • [X] I have run fig restart and replicated the issue again

Operating system

macOS 13.3.1 (22E261)

Expected behaviour

The highlight for a selection in fig when using Solarized Light theme matches preview in settings: image

Actual behaviour

The highlight is blue, kind of like MacOS right click menu blue; often hard to see the highlighted option:

Screenshot 2023-04-20 at 8 43 25 PM

Steps to reproduce

  1. Set theme to solarized light
  2. open terminal or vscode
  3. start typing, see fig pop up
  4. highlighted option in fig is not what's expected

Environment

fig-details:
  - 2.15.0
hardware-info:
  - model: 
  - model-id: 
  - chip-id: Apple M1 Pro
  - cores: 8
  - mem: 16.00 GB
os-info:
  - macOS 13.3.1 (22E261)
environment:
  - shell: /bin/zsh
  - terminal: vscode
  - cwd: /Users/achristmascarl/Code/Gatherly/poorManVR
  - exe-path: /opt/homebrew/bin/fig
  - install-method: brew
  - env-vars:
    - FIGTERM_SESSION_ID: 8b3d7c59-4127-4b45-b849-2b7e4222f850
    - FIG_SET_PARENT_CHECK: 1
    - FIG_TERM: 2.15.0
    - PATH: /Users/achristmascarl/.local/share/fig/plugins/git-open:/Users/achristmascarl/opt/anaconda3/bin:/Users/achristmascarl/opt/anaconda3/condabin:/Users/achristmascarl/.nvm/versions/node/v18.15.0/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/Apple/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Users/achristmascarl/.fig/bin:/Users/achristmascarl/.local/bin
    - SHELL: /bin/zsh
    - TERM: xterm-256color
    - ZDOTDIR: /Users/achristmascarl
    - __CFBundleIdentifier: com.microsoft.VSCode
    - FIG_PID: 39739
    - FIG_SET_PARENT: 8b3d7c59-4127-4b45-b849-2b7e4222f850

achristmascarl avatar Apr 21 '23 00:04 achristmascarl

You can modify all Fig themes by going to ~/Library/Application\ Support/fig/themes/themes/

mschrage avatar May 01 '23 19:05 mschrage

oh nice; thanks @mschrage!

achristmascarl avatar May 01 '23 20:05 achristmascarl