autocomplete icon indicating copy to clipboard operation
autocomplete copied to clipboard

feat(lightdash) add lightdash

Open kiliantscherny opened this issue 9 months ago • 8 comments

Created specs for Lightdash

kiliantscherny avatar May 01 '25 13:05 kiliantscherny

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

withfig-bot avatar May 01 '25 13:05 withfig-bot

Overview

src/lightdash.ts:

Info:

withfig-bot avatar May 01 '25 13:05 withfig-bot

Hello @kiliantscherny, thank you very much for creating a Pull Request! Here is a small checklist to get this PR merged as quickly as possible:

  • [ ] Do all subcommands / options which take arguments include the args property (args: {})?
  • [ ] Are all options modular? E.g. -a -u -x instead of -aux
  • [ ] Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

withfig-bot avatar May 01 '25 13:05 withfig-bot

I have read the CLA Document and I hereby sign the CLA

kiliantscherny avatar May 01 '25 13:05 kiliantscherny

@kiliantscherny Can you fix formatting lints?

chaynabors avatar May 19 '25 15:05 chaynabors

@chaynabors just fixed them now 👍

When I run pnpm lint locally I'm getting these errors:

❯ pnpm lint

> @withfig/[email protected] lint /Users/kiliantscherny/Documents/Development/Personal/autocomplete
> eslint '**/*.ts' && npx prettier --check '**/*.ts' --parser typescript


/Users/kiliantscherny/Documents/Development/Personal/autocomplete/build/dynamic/index.d.ts
  3:18  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 1 problem (1 error, 0 warnings)

 ELIFECYCLE  Command failed with exit code 1.

Not sure if that's going to be an issue nor how to resolve it

kiliantscherny avatar May 21 '25 12:05 kiliantscherny

Hi @chaynabors @mschrage would I be able to get your review on this when you get the chance? Thanks!

kiliantscherny avatar Jul 23 '25 10:07 kiliantscherny

Hey @chaynabors @mschrage is this good to get merged? Cheers

kiliantscherny avatar Sep 04 '25 08:09 kiliantscherny