docs icon indicating copy to clipboard operation
docs copied to clipboard

Update aliases.mdx

Open eric-burel opened this issue 1 year ago • 3 comments

Description (required)

Currently I think the change in tsconfig.json is not picked up by the dev server, which can be confusing. Not sure if it's a limitation of Astro or Vite but anyway the doc could mention it

Related issues & labels (optional)

  • Closes #
  • Suggested label:

eric-burel avatar Feb 22 '24 17:02 eric-burel

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 28, 2024 6:09pm

vercel[bot] avatar Feb 22 '24 17:02 vercel[bot]

I did not faced alias changes affecting the development server, it can also be because I am using existing themes from astro.build with nothing much todo in tsconfig file

Mayank-Malviya avatar Feb 23 '24 06:02 Mayank-Malviya

This might be a transient bug though so feel free to dismiss the PR, I'll try to repro and open a bug ticket if I reproduce consistently. However maybe the doc could mention explicitly that the server should automatically restart, so if somehow the alias change is not caught up user will figure they just need to kill it or it's a cache issue (they'll figure it anyway most of the time but this can trip beginners/tired devs)

eric-burel avatar Feb 23 '24 22:02 eric-burel

Hey @eric-burel thanks for opening a PR on this! I tried reproducing this locally, but I couldn't get it to break. The dev server is restarting, and types are updating when I make changes to tsconfig.ts. Even though this doesn't seem to be an issue, the docs could be more explicit about the dev server restarting when making these changes. I am going to approve Sarah's suggestion and merge this, thanks again! 🚀

BryceRussell avatar Mar 28 '24 17:03 BryceRussell