withastro
feat: explain the limitations of serialization
Description (required)
Documents the limitation of props for framework components, and server island components.
Related issues & labels (optional)
- Closes #9557
- Suggested label:
Deploy Preview for astro-docs-2 ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 28e55da2ec54f8c6b6dc6f72bdbb16e2c52a1762 |
| Latest deploy log | https://app.netlify.com/projects/astro-docs-2/deploys/6883d8c2bd3fd50008884f84 |
| Deploy Preview | https://deploy-preview-10944--astro-docs-2.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Lunaria Status Overview
🌕 This pull request will trigger status changes.
Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.
Tracked Files
| File | Note |
|---|---|
| en/guides/framework-components.mdx | Source changed, localizations will be marked as outdated. |
| en/guides/server-islands.mdx | Source changed, localizations will be marked as outdated. |
Warnings reference
| Icon | Description |
|---|---|
| 🔄️ | The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied. |
Thanks for jumping on this issue, Brandon! 🙌 It's looking pretty good, but I think this is now verging into "not a caution" territory, so I'm going to think about about making it just regular body text or at most a "note." Just waiting for some other feedback on this, but very happy to have this!!
Hey Sarah! I rewrote the middle sentence, and I moved it around a bit. Hopefully that seems to be a meaningful improvement!
Thanks for this additional helpful context, Fryuni!
(And nice job to get a "technically correct" out of Fryuni, @branberry ! 😄 Would you be willing to tackle the extra sections mentioned above?)
Hey @sarah11918 and @Fryuni, thank you so much for the thorough code review, I really do appreciate it. It's been incredibly helpful, and I've learned a good deal. Working on those extra sections now!
Just pinging this for freshness to see if you're still working on this @branberry ! 🙌
Hi @sarah11918 ! Thank you for pinging me. Apologies, this has fallen off of my radar. I'll pick this back up soon. Again, sorry about the delay with this one.
Consider this a friendly ping @branberry ! I know life gets in the way, so you can let us know if you're no longer interested/available if it's helpful to take it off your plate!
Hi Sarah, thank you for the very thoughtful ping. I've been meaning to get back around to this, but like you said, life has a way of getting in the way of things 😅 If this could be taken off my plate, that would be great. My apologies for the lack of communication.
No worries! I believe @Fryuni is going to take over with this one and finish it off. Thank you for helping us get it this far! 🚀
Gentle ping @Fryuni to see if you're still interested in working on this!
Ok, this was a great PR that needed some love! I took a shot at addressing @Fryuni 's comments so we could maybe "git 'er done" as NWTWWHB (Not Worse Than What We Had Before).
If what I wrote isn't incorrect, I'm going to suggest we merge so we can get this helpful content in docs! It can always be updated/improved again later!