hipsternet icon indicating copy to clipboard operation
hipsternet copied to clipboard

l1_regression loss is calling regularization with reg_type='l2'

Open cassidys opened this issue 7 years ago • 0 comments

from hipsternet/hipsternet/loss.py line 112

def l1_regression(model, y_pred, y_train, lam=1e-3):
    m = y_pred.shape[0]

    data_loss = np.sum(np.abs(y_train - y_pred)) / m
    reg_loss = regularization(model, reg_type='l2', lam=lam)  #<----- should this be l1 not l2

    return data_loss + reg_loss

Shouldn't it be calling regularization with reg_type='l1' and not 'l2'?

cassidys avatar Jul 27 '18 12:07 cassidys