wire-webapp icon indicating copy to clipboard operation
wire-webapp copied to clipboard

fix: Do not stick to bottom of messages list when navigating messages [WPB-2505]

Open atomrc opened this issue 1 year ago • 1 comments

BugWPB-2505 [Web] Automatic scroll to bottom of loaded message chunk after navigation to old messages

Description

This will avoid automatic scrolling when we reach the bottom of the messages list and the app loads more subsequent messages.

Screenshots/Screencast (for UI changes)

Before

https://github.com/wireapp/wire-webapp/assets/1090716/2d7317f7-c912-42a5-b8e7-25a000387147

After

https://github.com/wireapp/wire-webapp/assets/1090716/8ed589a8-4ba5-4f15-ae7f-2e4cc1e0a88f

Checklist

  • [x] PR has been self reviewed by the author;
  • [x] Hard-to-understand areas of the code have been commented;
  • [x] If it is a core feature, unit tests have been added;

atomrc avatar Feb 15 '24 14:02 atomrc

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (143186f) 45.91% compared to head (7f07d8c) 45.95%. Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #16850      +/-   ##
==========================================
+ Coverage   45.91%   45.95%   +0.03%     
==========================================
  Files         747      748       +1     
  Lines       24493    24495       +2     
  Branches     5593     5593              
==========================================
+ Hits        11247    11256       +9     
+ Misses      11814    11810       -4     
+ Partials     1432     1429       -3     

codecov[bot] avatar Feb 15 '24 15:02 codecov[bot]