wire-webapp icon indicating copy to clipboard operation
wire-webapp copied to clipboard

feat: login page (ACC-82)

Open przemvs opened this issue 3 years ago • 2 comments

SubtaskACC-82 Login & Signup


PR Submission Checklist for internal contributors

  • The PR Title

    • [ ] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [ ] contains a reference JIRA issue number like SQPIT-764
    • [ ] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • [ ] GitHub link to other pull request

Testing

Test Coverage (Optional)

  • [ ] I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

przemvs avatar May 17 '22 11:05 przemvs

Codecov Report

Merging #13030 (61d55b9) into dev (241604b) will increase coverage by 0.00%. The diff coverage is 55.55%.

:exclamation: Current head 61d55b9 differs from pull request most recent head f98b5b8. Consider uploading reports for the commit f98b5b8 to get more accurate results

@@           Coverage Diff           @@
##              dev   #13030   +/-   ##
=======================================
  Coverage   38.49%   38.49%           
=======================================
  Files         553      553           
  Lines       20812    20833   +21     
  Branches     4374     4380    +6     
=======================================
+ Hits         8011     8020    +9     
- Misses      11858    11867    +9     
- Partials      943      946    +3     

codecov[bot] avatar May 17 '22 11:05 codecov[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 10 '23 07:05 CLAassistant