wire-server icon indicating copy to clipboard operation
wire-server copied to clipboard
verified publisher icon wireapp

Bump mls-test-cli

Open smatting opened this issue 3 years ago • 2 comments

Updated mls-test-cli dependency, and the pin nixpkgs itself. Also removed the nixpkgs pin for building the docs.

This required some fiddling with rust dependencies (in particular the ring crate), since it seems to require the presence of a .git directory in order to build successfully. Hopefully this kludge can be removed eventually once the rust libraries mature.

Checklist

  • [x] The PR Title explains the impact of the change.
  • [x] The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • [x] If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.

smatting avatar Aug 11 '22 16:08 smatting

The problem seems to be that the patch is applied on the wrong directory (source, instead of the root where the vendor directory resides). Adding .. to the patch path would fix this, but then the patch is rejected:

Ignoring potentially dangerous file name ../mls-test-cli-0.3.0-vendor.tar.gz/ring/.git/placeholder

pcapriotti avatar Aug 12 '22 08:08 pcapriotti

Using a different hook (cargoDepsHook) instead of patch seems to have worked.

pcapriotti avatar Aug 12 '22 11:08 pcapriotti