wire-android icon indicating copy to clipboard operation
wire-android copied to clipboard

feat: Show folders in files list (WPB-17392)

Open ohassine opened this issue 9 months ago • 2 comments

TaskWPB-17392 Show folders in files screen


PR Submission Checklist for internal contributors

  • The PR Title

    • [ ] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [ ] contains a reference JIRA issue number like SQPIT-764
    • [ ] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • [ ] GitHub link to other pull request

Testing

Test Coverage (Optional)

  • [ ] I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

ohassine avatar Apr 29 '25 08:04 ohassine

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

pull-request-size[bot] avatar Apr 29 '25 08:04 pull-request-size[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.00%. Comparing base (582145a) to head (5069473).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4007   +/-   ##
========================================
  Coverage    46.00%   46.00%           
========================================
  Files          520      520           
  Lines        18124    18124           
  Branches      3053     3053           
========================================
  Hits          8338     8338           
  Misses        8921     8921           
  Partials       865      865           
Files with missing lines Coverage Δ
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <ø> (ø)
...ions/model/messagetypes/asset/AssetMessageTypes.kt 0.00% <ø> (ø)
...getypes/multipart/MultipartAttachmentsViewModel.kt 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 582145a...5069473. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 08 '25 10:05 codecov[bot]

Built wire-android-staging-compat-pr-4007.apk is available for download

github-actions[bot] avatar May 12 '25 12:05 github-actions[bot]

Built wire-android-dev-debug-pr-4007.apk is available for download

github-actions[bot] avatar May 12 '25 12:05 github-actions[bot]

Built wire-android-staging-compat-pr-4007.apk is available for download

github-actions[bot] avatar May 13 '25 08:05 github-actions[bot]

Built wire-android-dev-debug-pr-4007.apk is available for download

github-actions[bot] avatar May 13 '25 08:05 github-actions[bot]

Built wire-android-staging-compat-pr-4007.apk is available for download

github-actions[bot] avatar May 14 '25 09:05 github-actions[bot]

Built wire-android-dev-debug-pr-4007.apk is available for download

github-actions[bot] avatar May 14 '25 09:05 github-actions[bot]