wire-android icon indicating copy to clipboard operation
wire-android copied to clipboard

fix: No red shields visible on devices list from other users [WPB-8677] πŸ’ πŸ’

Open github-actions[bot] opened this issue 1 year ago β€’ 2 comments

This PR was automatically cherry-picked based on the following PR:

  • #2979

Original PR description:


BugWPB-8677 [Android] No red shields visible on devices list from other users

This PR was automatically cherry-picked based on the following PR:

  • #2977

Original PR description:


What's new in this PR?

Issues

Icons for "Revoked" and "Expired" E2EI certificates are not displayed in DevicesList in OtherUserProfile screen

Causes (Optional)

Were hidden (misunderstanding with designs)

Solutions

Show them when needed

github-actions[bot] avatar May 15 '24 09:05 github-actions[bot]

Build 4752 succeeded.

The build produced the following APK's:

AndroidBob avatar May 15 '24 10:05 AndroidBob

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.20%. Comparing base (f096658) to head (db5373b).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3006      +/-   ##
===========================================
- Coverage    44.35%   44.20%   -0.15%     
===========================================
  Files          447      447              
  Lines        14559    14558       -1     
  Branches      2498     2497       -1     
===========================================
- Hits          6457     6435      -22     
- Misses        7399     7427      +28     
+ Partials       703      696       -7     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update f096658...db5373b. Read the comment docs.

codecov-commenter avatar May 20 '24 10:05 codecov-commenter

Test Results

932 tests  Β±0   932 :white_check_mark: Β±0   8m 22s :stopwatch: - 3m 36s 124 suites Β±0     0 :zzz: Β±0  124 files   Β±0     0 :x: Β±0 

Results for commit db5373b2. ± Comparison against base commit f0966586.

github-actions[bot] avatar May 20 '24 10:05 github-actions[bot]

APKs built during tests are available here. Scroll down to Artifacts!

github-actions[bot] avatar May 20 '24 10:05 github-actions[bot]

Build 4808 succeeded.

The build produced the following APK's:

AndroidBob avatar May 20 '24 10:05 AndroidBob