wire-android icon indicating copy to clipboard operation
wire-android copied to clipboard

feat: multiple image preview [WPB-8801]

Open Garzas opened this issue 1 year ago • 11 comments

TaskWPB-8801 [Android] preview images and files when sending them through files button


PR Submission Checklist for internal contributors

  • The PR Title

    • [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [x] contains a reference JIRA issue number like SQPIT-764
    • [x] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • asset file preview to show generic file description in asset preview screen
  • asset tile preview for images, generic files and only extension preview
  • support for multiple images/files selection
  • support for legal hold for multiple messages in preview and import media
  • support for sending already handled AttachmentPickedBundle and not handled UriPickedBundle
  • removed unnecessary imported media models
  • divided imported and remote asset composables for better readability
  • fixed mock image for previews (without borders)

TODO

  • better handling screen navigation after messages sent errors
  • show dialog when one of messages are too big (models are already prepared)
  • removing asset functionality in import media screen
  • show too large file indicator in import media previews

Attachments (Optional)


PR Post Submission Checklist for internal contributors (Optional)

  • [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Garzas avatar May 15 '24 06:05 Garzas

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

pull-request-size[bot] avatar May 15 '24 06:05 pull-request-size[bot]

Test Results

931 tests  ±0   931 :white_check_mark: ±0   12m 21s :stopwatch: +26s 124 suites ±0     0 :zzz: ±0  124 files   ±0     0 :x: ±0 

Results for commit 2ad87967. ± Comparison against base commit c4d8002d.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 15 '24 07:05 github-actions[bot]

Build 4745 failed.

AndroidBob avatar May 15 '24 07:05 AndroidBob

Codecov Report

Attention: Patch coverage is 34.75177% with 92 lines in your changes are missing coverage. Please review.

Project coverage is 44.36%. Comparing base (c4d8002) to head (2ad8796).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3004      +/-   ##
===========================================
+ Coverage    44.29%   44.36%   +0.07%     
===========================================
  Files          448      450       +2     
  Lines        14519    14517       -2     
  Branches      2493     2497       +4     
===========================================
+ Hits          6431     6441      +10     
+ Misses        7385     7366      -19     
- Partials       703      710       +7     
Files Coverage Δ
.../ui/home/conversations/MessageComposerViewState.kt 84.84% <100.00%> (+4.84%) :arrow_up:
...conversations/messages/item/MessageTypesPreview.kt 0.00% <ø> (ø)
.../conversations/messages/item/RegularMessageItem.kt 0.00% <ø> (ø)
...ndroid/ui/home/conversations/model/MessageTypes.kt 85.00% <ø> (ø)
...droid/ui/home/messagecomposer/AttachmentOptions.kt 0.00% <ø> (ø)
...ions/model/messagetypes/asset/AssetMessageTypes.kt 0.00% <0.00%> (ø)
...com/wire/android/util/ui/WireSessionImageLoader.kt 19.23% <0.00%> (ø)
...onversations/media/preview/ImagesPreviewNavArgs.kt 0.00% <0.00%> (ø)
...e/android/util/permission/UseStorageRequestFlow.kt 0.00% <0.00%> (ø)
...oid/ui/home/messagecomposer/model/MessageBundle.kt 77.77% <0.00%> (-9.73%) :arrow_down:
... and 10 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c4d8002...2ad8796. Read the comment docs.

codecov-commenter avatar May 15 '24 07:05 codecov-commenter

APKs built during tests are available here. Scroll down to Artifacts!

github-actions[bot] avatar May 15 '24 07:05 github-actions[bot]

Build 4747 succeeded.

The build produced the following APK's:

AndroidBob avatar May 15 '24 08:05 AndroidBob

Build 4777 failed.

AndroidBob avatar May 16 '24 11:05 AndroidBob

Build 4778 failed.

AndroidBob avatar May 16 '24 12:05 AndroidBob

APKs built during tests are available here. Scroll down to Artifacts!

github-actions[bot] avatar May 16 '24 13:05 github-actions[bot]

Build 4780 succeeded.

The build produced the following APK's:

AndroidBob avatar May 16 '24 13:05 AndroidBob

Build 4996 failed.

AndroidBob avatar May 27 '24 10:05 AndroidBob

APKs built during tests are available here. Scroll down to Artifacts!

github-actions[bot] avatar May 27 '24 12:05 github-actions[bot]

Build 4998 succeeded.

The build produced the following APK's:

AndroidBob avatar May 27 '24 12:05 AndroidBob