feat: multiple image preview [WPB-8801]
|
|
PR Submission Checklist for internal contributors
-
The PR Title
- [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- [x] contains a reference JIRA issue number like
SQPIT-764 - [x] answers the question: If merged, this PR will: ... ³
-
The PR Description
- [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability
What's new in this PR?
- asset file preview to show generic file description in asset preview screen
- asset tile preview for images, generic files and only extension preview
- support for multiple images/files selection
- support for legal hold for multiple messages in preview and import media
- support for sending already handled AttachmentPickedBundle and not handled UriPickedBundle
- removed unnecessary imported media models
- divided imported and remote asset composables for better readability
- fixed mock image for previews (without borders)
TODO
- better handling screen navigation after messages sent errors
- show dialog when one of messages are too big (models are already prepared)
- removing asset functionality in import media screen
- show too large file indicator in import media previews
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
- [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue
PR Post Merge Checklist for internal contributors
- [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
- https://sparkbox.com/foundry/semantic_commit_messages
- https://github.com/wireapp/.github#usage
- E.g.
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.
Ups 🫰🟨
This PR is too big. Please try to break it up into smaller PRs.
Test Results
931 tests  ±0   931 :white_check_mark: ±0   12m 21s :stopwatch: +26s 124 suites ±0     0 :zzz: ±0  124 files   ±0     0 :x: ±0 
Results for commit 2ad87967. ± Comparison against base commit c4d8002d.
:recycle: This comment has been updated with latest results.
Build 4745 failed.
Codecov Report
Attention: Patch coverage is 34.75177% with 92 lines in your changes are missing coverage. Please review.
Project coverage is 44.36%. Comparing base (
c4d8002) to head (2ad8796).
Additional details and impacted files
@@ Coverage Diff @@
## develop #3004 +/- ##
===========================================
+ Coverage 44.29% 44.36% +0.07%
===========================================
Files 448 450 +2
Lines 14519 14517 -2
Branches 2493 2497 +4
===========================================
+ Hits 6431 6441 +10
+ Misses 7385 7366 -19
- Partials 703 710 +7
| Files | Coverage Δ | |
|---|---|---|
| .../ui/home/conversations/MessageComposerViewState.kt | 84.84% <100.00%> (+4.84%) |
:arrow_up: |
| ...conversations/messages/item/MessageTypesPreview.kt | 0.00% <ø> (ø) |
|
| .../conversations/messages/item/RegularMessageItem.kt | 0.00% <ø> (ø) |
|
| ...ndroid/ui/home/conversations/model/MessageTypes.kt | 85.00% <ø> (ø) |
|
| ...droid/ui/home/messagecomposer/AttachmentOptions.kt | 0.00% <ø> (ø) |
|
| ...ions/model/messagetypes/asset/AssetMessageTypes.kt | 0.00% <0.00%> (ø) |
|
| ...com/wire/android/util/ui/WireSessionImageLoader.kt | 19.23% <0.00%> (ø) |
|
| ...onversations/media/preview/ImagesPreviewNavArgs.kt | 0.00% <0.00%> (ø) |
|
| ...e/android/util/permission/UseStorageRequestFlow.kt | 0.00% <0.00%> (ø) |
|
| ...oid/ui/home/messagecomposer/model/MessageBundle.kt | 77.77% <0.00%> (-9.73%) |
:arrow_down: |
| ... and 10 more |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update c4d8002...2ad8796. Read the comment docs.
APKs built during tests are available here. Scroll down to Artifacts!
Build 4777 failed.
Build 4778 failed.
APKs built during tests are available here. Scroll down to Artifacts!
Build 4996 failed.
Quality Gate passed
Issues
6 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
APKs built during tests are available here. Scroll down to Artifacts!