wire-android icon indicating copy to clipboard operation
wire-android copied to clipboard

refactor: remove rememberRipple, unify calling icon buttons

Open saleniuk opened this issue 1 year ago • 4 comments


PR Submission Checklist for internal contributors

  • The PR Title

    • [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [ ] contains a reference JIRA issue number like SQPIT-764
    • [x] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [x] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When updating compose version, there were some problems with rememberRipple as it has been updated/changed in the compose library. Having custom ripples set in the app may lead to some wrong colors chosen for the indication or ripple not covering or going beyond the element if the shape is not correct.

Solutions

Removed all rememberRipple in the app, instead rely on the default indication type and colour based on the theme. Added ripple colors to button color scheme to enable setting different ripple colors for different button states in the theme. Unified all calling icon buttons so that they are consistent, have correct types, reuse the same elements and are in line with designs. Fixed previews and added some more where missing.

Testing

How to Test

Open calling screens and click on round calling icon buttons.


PR Post Submission Checklist for internal contributors (Optional)

  • [x] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [x] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

saleniuk avatar May 10 '24 16:05 saleniuk

Test Results

928 tests  ±0   928 :white_check_mark: ±0   14m 48s :stopwatch: + 4m 41s 123 suites ±0     0 :zzz: ±0  123 files   ±0     0 :x: ±0 

Results for commit 6cfb5c9c. ± Comparison against base commit 24769c4b.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 10 '24 16:05 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.15%. Comparing base (24769c4) to head (6cfb5c9).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2998      +/-   ##
===========================================
+ Coverage    44.00%   44.15%   +0.14%     
===========================================
  Files          447      447              
  Lines        14547    14548       +1     
  Branches      2497     2498       +1     
===========================================
+ Hits          6402     6423      +21     
+ Misses        7451     7424      -27     
- Partials       694      701       +7     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 24769c4...6cfb5c9. Read the comment docs.

codecov-commenter avatar May 10 '24 17:05 codecov-commenter

APKs built during tests are available here. Scroll down to Artifacts!

github-actions[bot] avatar May 10 '24 17:05 github-actions[bot]

Build 4718 succeeded.

The build produced the following APK's:

AndroidBob avatar May 10 '24 18:05 AndroidBob

APKs built during tests are available here. Scroll down to Artifacts!

github-actions[bot] avatar May 15 '24 15:05 github-actions[bot]

Build 4762 succeeded.

The build produced the following APK's:

AndroidBob avatar May 15 '24 16:05 AndroidBob