wire-android icon indicating copy to clipboard operation
wire-android copied to clipboard

fix: show last deleted message [WPB-1899]

Open Garzas opened this issue 1 year ago • 4 comments

BugWPB-1899 Wrong conversation second line when someone deletes the last message


PR Submission Checklist for internal contributors

  • The PR Title

    • [ ] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [ ] contains a reference JIRA issue number like SQPIT-764
    • [ ] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

All deleted messages were filtered from message previews

Causes (Optional)

Conversations showed last message before deleted message

Solutions

Remove deleted message previews filtering and introduce new Deleted content

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box) last_deleted_message

Garzas avatar May 10 '24 11:05 Garzas

Build 4708 failed.

AndroidBob avatar May 10 '24 11:05 AndroidBob

Test Results

928 tests  +1   928 :white_check_mark: +1   8m 39s :stopwatch: - 6m 21s 123 suites ±0     0 :zzz: ±0  123 files   ±0     0 :x: ±0 

Results for commit 42eeb6ec. ± Comparison against base commit bcee8486.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 10 '24 14:05 github-actions[bot]

Build 4710 failed.

AndroidBob avatar May 10 '24 14:05 AndroidBob

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.31%. Comparing base (bcee848) to head (42eeb6e).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2996      +/-   ##
===========================================
+ Coverage    44.29%   44.31%   +0.02%     
===========================================
  Files          444      444              
  Lines        14488    14492       +4     
  Branches      2492     2493       +1     
===========================================
+ Hits          6417     6422       +5     
+ Misses        7373     7369       -4     
- Partials       698      701       +3     
Files Coverage Δ
...wire/android/mapper/MessagePreviewContentMapper.kt 57.52% <100.00%> (+1.48%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bcee848...42eeb6e. Read the comment docs.

codecov-commenter avatar May 13 '24 06:05 codecov-commenter

APKs built during tests are available here. Scroll down to Artifacts!

github-actions[bot] avatar May 13 '24 06:05 github-actions[bot]

Build 4721 succeeded.

The build produced the following APK's:

AndroidBob avatar May 13 '24 07:05 AndroidBob