wire-android icon indicating copy to clipboard operation
wire-android copied to clipboard

chore: file access crashes [WPB-7368] 🍒

Open github-actions[bot] opened this issue 1 year ago • 1 comments

This PR was automatically cherry-picked based on the following PR:

  • #2994

Original PR description:


BugWPB-7368 [Android] Playstore crash - Resample Image and File handling


PR Submission Checklist for internal contributors

  • The PR Title

    • [ ] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [ ] contains a reference JIRA issue number like SQPIT-764
    • [ ] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • added information about about available space and total device space to datadog
  • added snackbar message when access to file on avatar upload fails
  • added more logs when resampling images
  • code cleanup

github-actions[bot] avatar May 10 '24 10:05 github-actions[bot]

Build 4704 succeeded.

The build produced the following APK's:

AndroidBob avatar May 10 '24 11:05 AndroidBob

Codecov Report

Attention: Patch coverage is 19.35484% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 44.07%. Comparing base (08879d3) to head (d5d0a84).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2995      +/-   ##
===========================================
- Coverage    44.31%   44.07%   -0.25%     
===========================================
  Files          444      445       +1     
  Lines        14492    14524      +32     
  Branches      2493     2497       +4     
===========================================
- Hits          6422     6401      -21     
- Misses        7369     7429      +60     
+ Partials       701      694       -7     
Files Coverage Δ
.../userprofile/avatarpicker/AvatarPickerViewModel.kt 82.35% <66.66%> (-4.95%) :arrow_down:
.../src/main/kotlin/com/wire/android/util/FileUtil.kt 6.48% <0.00%> (-0.73%) :arrow_down:
...rc/main/kotlin/com/wire/android/util/DeviceUtil.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08879d3...d5d0a84. Read the comment docs.

codecov-commenter avatar May 14 '24 10:05 codecov-commenter

Test Results

928 tests  ±0   928 :white_check_mark: ±0   9m 21s :stopwatch: -31s 123 suites ±0     0 :zzz: ±0  123 files   ±0     0 :x: ±0 

Results for commit d5d0a846. ± Comparison against base commit 08879d3d.

github-actions[bot] avatar May 14 '24 10:05 github-actions[bot]

APKs built during tests are available here. Scroll down to Artifacts!

github-actions[bot] avatar May 14 '24 10:05 github-actions[bot]

Build 4730 succeeded.

The build produced the following APK's:

AndroidBob avatar May 14 '24 11:05 AndroidBob