wire-android icon indicating copy to clipboard operation
wire-android copied to clipboard

fix: incoming call screen is not shown on second account - cherrypick

Open ohassine opened this issue 1 year ago • 3 comments


PR Submission Checklist for internal contributors

  • The PR Title

    • [ ] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [ ] contains a reference JIRA issue number like SQPIT-764
    • [ ] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Cherrypick of https://github.com/wireapp/wire-android/pull/2956

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • [ ] GitHub link to other pull request

Testing

Test Coverage (Optional)

  • [ ] I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

ohassine avatar May 02 '24 16:05 ohassine

Test Results

924 tests   924 :white_check_mark:  9m 4s :stopwatch: 123 suites    0 :zzz: 123 files      0 :x:

Results for commit 19a2af8c.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 02 '24 16:05 github-actions[bot]

APKs built during tests are available here. Scroll down to Artifacts!

github-actions[bot] avatar May 02 '24 16:05 github-actions[bot]

Build 4571 succeeded.

The build produced the following APK's:

AndroidBob avatar May 02 '24 17:05 AndroidBob

Build 4576 succeeded.

The build produced the following APK's:

AndroidBob avatar May 03 '24 09:05 AndroidBob

APKs built during tests are available here. Scroll down to Artifacts!

github-actions[bot] avatar May 03 '24 10:05 github-actions[bot]