wire-android icon indicating copy to clipboard operation
wire-android copied to clipboard

feat: allow swipe to reply (WPB-982) 🍒

Open github-actions[bot] opened this issue 1 year ago • 1 comments

This PR was automatically cherry-picked based on the following PR:

  • #2955

Original PR description:


StoryWPB-982 Swipe right to reply to a message


PR Submission Checklist for internal contributors

  • The PR Title

    • [X] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [X] contains a reference JIRA issue number like SQPIT-764
    • [X] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [X] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Self explanatory, innit?

Solutions

Use SwipeToDismissBoxState.

  • Always reject state changes, so after the drag animation it goes back to settled.

Extracted the whole drag animation logic and icon setup into SwipableToReplyBox. It can be modified to allow swiping to multiple directions with different actions later on.

Testing

Not really testable at the moment. It's all UI.

Attachments

Light and Dark theme usage

https://github.com/wireapp/wire-android/assets/9389043/83658c0a-187f-410f-a73b-abe57f956bd4

Back gesture support

https://github.com/wireapp/wire-android/assets/9389043/15016377-e629-4080-84a0-5831302226ac


PR Post Merge Checklist for internal contributors

  • [X] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

github-actions[bot] avatar May 02 '24 14:05 github-actions[bot]

Build 4562 succeeded.

The build produced the following APK's:

AndroidBob avatar May 02 '24 16:05 AndroidBob

APKs built during tests are available here. Scroll down to Artifacts!

github-actions[bot] avatar May 03 '24 12:05 github-actions[bot]