wire-android icon indicating copy to clipboard operation
wire-android copied to clipboard

fix(e2ei): set user display name correctly for the certificate downloaded file (WPB-8606)

Open mchenani opened this issue 1 year ago • 4 comments

BugWPB-8606 [Android] When downloading another users certificate, saved file has wrong name

…aded file


PR Submission Checklist for internal contributors

  • The PR Title

    • [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [x] contains a reference JIRA issue number like SQPIT-764
    • [x] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Set display name for the certificate downloaded file.

Issues

The self user name was set even for other users cert.

Causes (Optional)

Wasn't handled.


PR Post Submission Checklist for internal contributors (Optional)

  • [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

mchenani avatar Apr 26 '24 06:04 mchenani

Test Results

820 tests   820 :white_check_mark:  7m 55s :stopwatch: 110 suites    0 :zzz: 110 files      0 :x:

Results for commit 3b611108.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 26 '24 07:04 github-actions[bot]

Build 4477 failed.

AndroidBob avatar Apr 26 '24 07:04 AndroidBob

APKs built during tests are available here. Scroll down to Artifacts!

github-actions[bot] avatar Apr 26 '24 08:04 github-actions[bot]

Build 4478 succeeded.

The build produced the following APK's:

AndroidBob avatar Apr 26 '24 08:04 AndroidBob