wire-android icon indicating copy to clipboard operation
wire-android copied to clipboard

feat(config): separate lower KeyPackage limit and set to false (WPB-8685)

Open AndroidBob opened this issue 1 year ago β€’ 4 comments

TaskWPB-8685 [Android] Increase keypackages amount to 100 again on all builds

Cherry pick from the original PR:

  • #2927

⚠️ Conflicts during cherry-pick: kalium


PR Submission Checklist for internal contributors

  • The PR Title

    • [x] conforms to the style of semantic commits messagesΒΉ supported in Wire's Github WorkflowΒ²
    • [x] contains a reference JIRA issue number like
    • [x] answers the question: If merged, this PR will: ... Β³
  • The PR Description

    • [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Introducing dedicated config flag for LoweringKeypackagesLimit and set to as default.

Issues

The QA needs to have loweringKeyPackages in different builds configurable,


PR Post Submission Checklist for internal contributors (Optional)

  • [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

AndroidBob avatar Apr 23 '24 08:04 AndroidBob

Test Results

22 tests   -β€Š881   22 :white_check_mark:  -β€Š881   0s :stopwatch: - 9m 57s  5 suites  -β€Š118    0 :zzz: ±  0   5 files    -β€Š118    0 :x: ±  0 

Results for commit b3e4826c. ± Comparison against base commit 114d60a1.

This pull request removes 881 tests.
com.wire.android.GlobalObserversManagerTest ‑ given app not visible and valid session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and invalid session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and no session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and session failure, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and valid session, when handling ephemeral messages, then call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given few valid accounts, when starting observing accounts, then create user-specific notification channels()
com.wire.android.GlobalObserversManagerTest ‑ given valid accounts, at least one with persistent socket enabled, and socket service running, then do not start service again()
com.wire.android.GlobalObserversManagerTest ‑ given validAccounts and persistentStatuses are out of sync, when setting up notifications, then ignore invalid users()
com.wire.android.SelfDeletionTimerTest ‑ givenTimeLeftIs1DayAnd12Hours_whenRecalculatingTimeAfterIntervals_thenTimeLeftIsEqualToExpected()
com.wire.android.SelfDeletionTimerTest ‑ givenTimeLeftIs1HourAnd12Minutes_whenRecalculatingTimeAfterIntervals_thenTimeLeftIsEqualToExpected()
…

github-actions[bot] avatar Apr 23 '24 09:04 github-actions[bot]

Build 4390 failed.

AndroidBob avatar Apr 23 '24 09:04 AndroidBob

@mchenani should this PR also be cherry-picked into the current RC ?

MohamadJaara avatar May 03 '24 09:05 MohamadJaara

This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore.

github-actions[bot] avatar Jun 15 '24 00:06 github-actions[bot]

Built wire-android-staging-release-pr-2930.apk is available for download

github-actions[bot] avatar Jun 24 '24 09:06 github-actions[bot]

Built wire-android-dev-debug-pr-2930.apk is available for download

github-actions[bot] avatar Jun 24 '24 09:06 github-actions[bot]