core-crypto
core-crypto copied to clipboard
Fix/v1 schema 1.0.0 rc.6 [WPB-4946]
PR Submission Checklist for internal contributors
-
The PR Title
- [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- [x] contains a reference JIRA issue number like
SQPIT-764 - [x] answers the question: If merged, this PR will: ... ³
-
The PR Description
- [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability
References
- https://sparkbox.com/foundry/semantic_commit_messages
- https://github.com/wireapp/.github#usage
- E.g.
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.
Codecov Report
Merging #412 (bec0149) into develop (f2fb4e3) will decrease coverage by
0.08%. Report is 135 commits behind head on develop. The diff coverage is0.00%.
@@ Coverage Diff @@
## develop #412 +/- ##
===========================================
- Coverage 73.61% 73.53% -0.08%
===========================================
Files 71 70 -1
Lines 12483 12492 +9
===========================================
- Hits 9189 9186 -3
- Misses 3294 3306 +12
| Files | Coverage Δ | |
|---|---|---|
| crypto/src/mls/conversation/commit_delay.rs | 91.48% <ø> (+0.09%) |
:arrow_up: |
| crypto/src/mls/credential/mod.rs | 81.94% <ø> (-4.87%) |
:arrow_down: |
| crypto/src/proteus.rs | 58.97% <ø> (ø) |
|
| keystore/src/connection/mod.rs | 86.31% <ø> (ø) |
|
| keystore/src/mls.rs | 63.67% <0.00%> (-1.06%) |
:arrow_down: |
... and 17 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update f2fb4e3...bec0149. Read the comment docs.
All important changes from this are already in develop, so we can close this.