winter icon indicating copy to clipboard operation
winter copied to clipboard

[WIP] Add support for Child Themes

Open jaxwilko opened this issue 3 years ago • 4 comments

This PR adds support for a theme to extend another theme via a parent: [themeName] directive in the theme.yaml. This PR also supports the theme.yaml being added as a DbDatasource content meaning that an extending theme can be purely driven by the DB.

Storm PR: https://github.com/wintercms/storm/pull/123

jaxwilko avatar Oct 06 '22 14:10 jaxwilko

@jaxwilko Do we want this PR for 1.2.1 since it's still a draft?

mjauvin avatar Oct 07 '22 19:10 mjauvin

@mjauvin still got some bugs that need to be fixed before it's ready for review :)

jaxwilko avatar Oct 07 '22 19:10 jaxwilko

So it's mostly done, just has a few glitches?

mjauvin avatar Oct 07 '22 19:10 mjauvin

@mjauvin this functionality is needed for our project that we're launching in November so what release it's tagged for doesn't really matter since it'll be merged when it's ready. Don't consider it blocking against 1.2.1 though.

LukeTowers avatar Oct 08 '22 00:10 LukeTowers