mobx-logger icon indicating copy to clipboard operation
mobx-logger copied to clipboard

MobX Logger causing performance issues in Safari

Open samturner opened this issue 7 years ago • 1 comments

Hi there,

We're running into some issues with MobX logger and Safari (v 11.1.1). Whenever it is enabled it's causing the browser to hang when loading the app and making changes to MobX stores.

Our enableLogging currently looks like this:

    enableLogging({
      predicate: () => true,
      action: true,
      reaction: false,
      transaction: false,
      compute: false
    });

Happy to do some testing to figure this out!

samturner avatar Jul 05 '18 02:07 samturner

I've just tested my real world project with mobx 4 on latest Safari 11.1 and cannot reproduce the issues.

You should try to figure out if the problem is really caused by mobx-logger. E.g. try to disable mobx-logger, then setup a custom mobx spy listener and check if the issues are reproducible.

See: https://mobx.js.org/refguide/spy.html

winterbe avatar Jul 11 '18 13:07 winterbe