Yuxiang Liu

Results 27 comments of Yuxiang Liu

or we can add a callback onChangeEnd?

i think it's better to add onChangeEnd, it's not a breaking change ``` onChangeEnd: () { // do something } ```

typescript generate a larger hash(28 vs 36), it's strange

@ditclear I use code generator to use it easier and named parameters but _ParameterList is private, I can't specify type annotation like single(({ParameterList param})=>x()) Although it won't cause any problems,...

Just had a look into code. Maybe it doesn't even query the dictionary because word count > 1 https://github.com/tisfeng/Easydict/blob/main/Easydict/objc/Service/Apple/AppleDictionary/EZAppleDictionary.m#L126 https://github.com/tisfeng/Easydict/blob/2d0cf752df5fd3e7f31e5752409c801744d83f2a/Easydict/objc/Utility/EZCategory/NSString/NSString%2BEZUtils.m#L174 It appears Chinese bypasses the word count check in `shouldQueryDictionaryWithLanguage`...