deb-get icon indicating copy to clipboard operation
deb-get copied to clipboard

Keys moved to the wrong place

Open fethomm opened this issue 3 years ago • 6 comments

deb-get issue template

Thank you for taking the time to report an issue to the deb-get project 🙂

  • Please complete one the appropriate sections below.
  • Delete all the sections that do not apply, including this one.
  • Any issues that do not use this template will be closed.
  • If you're not sure what to do, or have a general question about deb-get, then ask in Wimpy's World Discord.

Requesting a new app ✨

If you are requesting a new app to be added to deb-get please complete the following section, only one app per issue please.

  • [ ] I have checked that this app does not already have a pending request and has not previously been declined.
  • App Name:
  • Download URL:
  • Website URL:
  • App Summary:

Requesting a new feature 🧑‍💻

If you are proposing a new feature for deb-get please describe the proposed feature with as much detail as possible here:

Reporting a bug 🐛

Please make sure the version of deb-get you are using is up to date:

deb-get update
deb-get reinstall deb-get

Expected behavior

Describe the expected behavior here. Keys of installed apps should go to /usr/share/keyrings

Actual behavior

Describe the actual behavior here. Keys of installed apps go to deprecated /etc/apt/trusted.gpg or etc/apt/trusted.gpg.d

Steps to reproduce

deb-get install foo and check where the key gets copied to Describe the exact steps required to reproduce the issue.

System information

Run the following a paste the output below:

/etc/os-release

Ubuntu 22.04

cat /etc/os-release


#### /etc/lsb-release

```bash
cat /etc/lsb-release

deb-get version

deb-get version
0.3.5
### deb-get update

```bash
deb-get update

fethomm avatar Sep 18 '22 11:09 fethomm

Hello there 👋 Thanks for submitting your first issue to the deb-get project 🐛 We'll try and take a look at your issue soon ⏲

In the meantime you might want to join the Wimpys World Discord 🗣 where we have a large community of Linux 🐧 enthusiasts and passionate open source developers 🧑‍💻

You might also be interested in following Wimpys World Twitch 📡 channel where Wimpy streams let's code video, including this project, several times a week. A back catalog of past live stream and other Linux related content is available on Wimpys World YouTube 📺 channel.

github-actions[bot] avatar Sep 18 '22 11:09 github-actions[bot]

After looking into it . Install deb function works as it's expected and adds key to keyring directory, however apt-add-repository is used in add_ppa function, which causing this issue as it's the old way still. Might need to be implement manually adding ppa to source list and keyring

takov751 avatar Sep 18 '22 12:09 takov751

Until there is a proper replacement. I was wondering if we should implement in such way from ppa:username:ppa_name just get the username and ppa_name as variable. Download key and move it to keyring then create file into sources.list.d echo "deb [arch=amd64 signed-by=/usr/share/keyrings/R.gpg] https://cloud.r-project.org/bin/linux/ubuntu jammy-cran40/" | sudo tee /etc/apt/sources.list.d/R.list > /dev/null something like this. and the filname should be debget_appname.list

takov751 avatar Sep 18 '22 15:09 takov751

@fethomm please read the issue template and use it correctly, so we know what is going on.

natanjunges avatar Sep 18 '22 16:09 natanjunges

He did used it, just left unused part of the template. @natanjunges

takov751 avatar Sep 18 '22 16:09 takov751

Sorry, it was hard to find the information. This is not exactly a bug, but I agree that adding the keyrings globally is not a good idea. I already intended to work on that, but there are some complications that require caution in the way we handle it.

natanjunges avatar Sep 18 '22 17:09 natanjunges