glmpca
glmpca copied to clipboard
Return factors and loadings as matrices instead of data frames
As pointed out by https://github.com/willtownes/scrna2019/issues/5 glmpca is returning factors as a data frame instead of a matrix (as the documentation claims), which causes downstream problems converting SingleCellExperiment objects to Seurat.
- Expose an option to allow the user to decide whether to return matrix or data frame
- Change the default to return matrices instead of data frames
The offending place in the code is here: https://github.com/willtownes/glmpca/blob/master/R/postprocess.R#L86
Tagging @liuzhe93 so she can keep track of progress here.
Tagging @liuzhe93 so she can keep track of progress here.
ok, thanks a lot. Thanks for your kind help.