William Platt
William Platt
@Jugen I assumed that while the subscribe function was running there couldn't be any more changes to the text. I thought all this code should be running on the FX...
@Jugen I understand that, but the `subscribe()` lambda shouldn't be called unless no changes have occurred during that wait period. Is the issue that that the timer runs on another...
I don't see the problem in your example. In my code both events will be passed to the subscribed listener, which will see the order in which the changes were...
@Symeon94 I agree that the code would be nicer if broken into small functions, but I'm aware others might have a different opinion. You're probably right that it would be...
@Jugen I think your summary of the bug and the fix is correct. I don't think we want to sort the changes on position because then you could have an...
@Jugen @Symeon94 I tried to incorporate both your suggestions, so please review again and hopefully it is clearer now.
Hi David, thanks for looking into this. I see my expectations were a bit beyond what you had intended for the suggestions to do yet then. The grammar I am...
Sounds great, thanks!
If you're able to provide what rule is being used for the CompletionItem and whether it's a rule already begun then I think that would be both more general and...
Okay, and I'd be able to tell if the suggestion is for finishing a rule already started because the offeredPosition would be before the requestedPosition?