wan comments

Results 73 comments of

wan

[REF] account: remove chart template

@robodoo r+

[IMP] account,base_hash,l10n_pt,l10n_fr: refactoring of the hash system + implementation in Portugal

I mean... We could name the module `shared_by_everyone_but_not_base_hash` but... Note that it isn't the first time a module is named like that, look at `base_vat`

[IMP] account,base_hash,l10n_pt,l10n_fr: refactoring of the hash system + implementation in Portugal

`stock` has nothing to do with `account` (except that they both use `base` :upside_down_face:)

[FIX] account: prevent wrong floating representation of currency

``` >>> move.line_ids[0].credit 2.5 >>> float_repr(move.line_ids[0].credit, 2) '2.50' ``` @robodoo r-

[IMP] models: avoid querying the database for sorted(key=None)

@ryv-odoo Thanks for the review and the suggestions :blush:

[IMP] models: avoid querying the database for sorted(key=None)

@ryv-odoo I believe this is very close (if not already there) to being mergeable, would be a shame to not merge it :blush:

[IMP] models: avoid querying the database for sorted(key=None)

@ryv-odoo Are there still things to do?

[IMP] models: avoid querying the database for sorted(key=None)

@ryv-odoo is there something I can do to make the review easier/faster for you?

[17.0][BUG] Mail Wizard in Account Move (only!) doesn't attach report specified in mail template, instead keeps default report

@smetl

[FIX] account, l10n_it_edi: allow multiple invoices in the same file

@lordkrandel I think that the process of the security would be faster if you could provide for each warning why you believe that there is no actual issue :wink: