Negotiation icon indicating copy to clipboard operation
Negotiation copied to clipboard
verified publisher icon willdurand

Fix to allow for use with PHP8

Open gforsythe-godaddy opened this issue 3 years ago • 2 comments

Previous code had a method named "match" which is now a restricted name.

gforsythe-godaddy avatar Jan 10 '23 23:01 gforsythe-godaddy

@willdurand (or any other maintainers) any chance at pulling this?

gforsythe-godaddy avatar Jan 19 '23 22:01 gforsythe-godaddy

Hello @willdurand can we accept this change? This is a very simple one that fixes few bugs for a very cheap cost.

Note that this bug still exist: PHP Parse error: syntax error, unexpected token "match" in /home/akeneo/akeneo/pim-releases/20221223101040Z/vendor/willdurand/negotiation/src/Negotiation/Negotiator.php on line 41 PHP 8.0.26 / Akeneo 6.0.71 / rest-bundle 3.0.5 / negociation 3.1.0.

Nayte91 avatar Mar 31 '23 16:03 Nayte91