Jeff Long
Jeff Long
Are you thinking of combining with #7638?
OK, so you were saying you want to wait and rebase this after the other PRs are applied?
I see the rebase - will check back later. Feels like we've just hit the season finale!
Starting to think we should drop testing on 20.04.
Note for maint-3.8 - PRs were not merged upstream, so do not apply patch. Default parameters would be required to avoid an API change.
Just took a quick look at the includes. It looks like the API should be backward compatible, but removing some of the include files will break build backward compatibility. What...
@R-ohit-B-isht this PR picked up a bunch of unrelated commits.
@R-ohit-B-isht I removed the include cmake changes and pushed to your branch. I'll work on removing the old code from the specialized include files.
@marcusmueller could you take a quick look. The only goal here is to reduce duplicate code, no improvements. The old include files are left as wrappers for the new ones,...
@marcusmueller I'll come back and clean up the things you mentioned another time ... not hurting anything for the moment and I want to get the RC out.