spectacle icon indicating copy to clipboard operation
spectacle copied to clipboard

Opening trace link loads forever

Open lemmy opened this issue 1 year ago • 4 comments

Opening the following trace link takes forever (spinning wheel next to "root spec") in Edge (Vivaldi) and Safari: https://will62794.github.io/tla-web/#!/home?specpath=https%3A%2F%2Fraw.githubusercontent.com%2Flemmy%2FCCF%2Fmku-ConsistencyMonolith%2Ftla%2Fconsistency%2FConsistency.tla&traceExprs%5B0%5D=AllCommittedObservedRoInv&trace=297cc69b%2Cd0b53816%2Cc64ffa94%2C28d6a04f%2C266f1e96%2C44617b58%2C551598da%2C150d05ea%2C14022610%2C74fe4aa9%2Cae2a49a2%2Cd54bbb48

lemmy avatar May 05 '24 17:05 lemmy

Screenshot of the tab in which I manually created the trace:

Screenshot 2024-05-05 at 10 48 43 AM

lemmy avatar May 05 '24 17:05 lemmy

This might be due to the spec at the github url being out of date.

lemmy avatar May 05 '24 18:05 lemmy

This link works: https://will62794.github.io/tla-web/#!/home?specpath=https%3A%2F%2Fraw.githubusercontent.com%2Flemmy%2FCCF%2Fmku-ConsistencyMonolith%2Ftla%2Fconsistency%2FConsistency.tla&trace=297cc69b%2Cd0b53816%2Cc64ffa94%2C28d6a04f%2C266f1e96%2C44617b58%2C551598da%2C150d05ea%2C14022610%2C74fe4aa9%2Cae2a49a2%2Cd54bbb48&traceExprs%5B0%5D=AllCommittedObservedRoInv

lemmy avatar May 05 '24 18:05 lemmy

This was indeed caused by the spec being outdated. Perhaps, add a checksum to links to gracefully fail if there is a mismatch.

lemmy avatar May 05 '24 18:05 lemmy

Closing unless you believe there is some other underlying bug here.

will62794 avatar May 17 '24 14:05 will62794

Like I said, the link could include a checksum over the spec, and error or warn if one loads an trace for a spec that does not match.

lemmy avatar May 17 '24 15:05 lemmy