react-css-transition icon indicating copy to clipboard operation
react-css-transition copied to clipboard

Type problem in 0.7.4 with Typescript 2.4.1 + react 15.6.1

Open estaub opened this issue 8 years ago • 0 comments

Typescript 2.4.1 reports when compiling csstransitiongroup.d.ts:

Error:(13, 5) TS2424:Class 'Component<CSSTransitionGroupProps, {}>' defines instance member function 'componentDidMount', but extended class 'CSSTransitionGroup' defines it as instance member property.

This is regarding:

export declare class CSSTransitionGroup extends Component<CSSTransitionGroupProps, {}> {
    static defaultProps: any;
    private mounted;
    componentDidMount: () => boolean;
    render(): JSX.Element;
}

which conflicts with the ComponentLifeCycle member:

componentDidMount?(): void; I'm surprised that Typescript would care whether it's a member function or member property. Note also that the React def claims componentDidMount() is optional and returns void, whereas react-css-transition claims it is required and returns boolean.

estaub avatar Jul 08 '17 21:07 estaub