language-data icon indicating copy to clipboard operation
language-data copied to clipboard
verified publisher icon wikimedia

pa-guru was just a duplicate of pa

Open satdeepgill opened this issue 3 years ago • 1 comments

Removed pa-guru as there were two ਪੰਜਾਬੀ options in Universal Language Selector. I have removed pa-guru as that was giving the error "pa-guru is not valid".

satdeepgill avatar May 20 '22 10:05 satdeepgill

Sorry about the delay, I somehow kept forgetting about this.

Unfortunately, I don't remember why did I add both pa and pa-guru. It happened in 2012, and I didn't properly document it. But there must have been some reason. Maybe the Punjabi of India appeared in CLDR as "pa-guru", or maybe some browsers sent "pa-guru", or maybe some other reason.

So I'm reluctant to remove pa-guru entirely. Perhaps pa-guru should redirect to pa, and not the other way around.

Also, I cannot see examples of Punjabi appearing twice. Do you have an example? If that happens, that's the actual bug, and it should be addressed separately, not by removing a code.

amire80 avatar Oct 25 '23 13:10 amire80

I spoke to @satdeepgill at Wikimania 2024 about this, and we identified the actual bug. It's not in language-data, but in ULS. It is supposed to collapse redirect languages into their target languages when identifying suggested languages, and it doesn't always do it. I've reported it here: https://phabricator.wikimedia.org/T372034 . I'm closing this pull request, and I'll fix the bug in the right place, in ULS. Thanks for raising the issue, and sorry it took so long to process it.

amire80 avatar Aug 27 '24 16:08 amire80