firfilt icon indicating copy to clipboard operation
firfilt copied to clipboard

Possible documentation inconsistency

Open arnodelorme opened this issue 6 years ago • 2 comments

Transfered from Bugzilla https://sccn.ucsd.edu/bugzilla/show_bug.cgi?id=1963

Filter order (filter length - 1) is computed automatically (no value in GUI or also CLI) the transition band width is computed before it is checked whether filter order is actually even (mandatory). In case not, it is rounded up to the next even integer. Thus, true transition band width is minimally smaller than expected.

Documentation inconsistent with function behavior - switch high pass and low pass parameters

arnodelorme avatar Dec 10 '19 21:12 arnodelorme

Filter order (filter length - 1) is computed automatically (no value in GUI or also CLI) the transition band width is computed before it is checked whether filter order is actually even (mandatory). In case not, it is rounded up to the next even integer. Thus, true transition band width is minimally smaller than expected.

You mean the value reported on the CLI in pop_eegfiltnew? Yes, indeed there might be a very small difference between reported and actual df due to rounding m to even integer. Will add a line recomputing df when I next time touch the function.

Documentation inconsistent with function behavior - switch high pass and low pass parameters

Sorry, I do have no clue what you mean? Could you please be more specific?

widmann avatar Sep 20 '21 14:09 widmann

Part one was fixed in 6501ec4. Could you please update the link in EEGLAB to version 912ff9e?

For part two ("Documentation inconsistent with function behavior - switch high pass and low pass parameters") I still need input. I do not know what you mean.

widmann avatar Feb 12 '24 14:02 widmann